make TestAdminLogsWindow more reliable#43710
Open
Ian321 wants to merge 1 commit intospace-wizards:masterfrom
Open
make TestAdminLogsWindow more reliable#43710Ian321 wants to merge 1 commit intospace-wizards:masterfrom
Ian321 wants to merge 1 commit intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
Contributor
|
Just to clarify: how'd you figure out that this was the problem? |
Contributor
Author
|
Tayrtahn
reviewed
Apr 24, 2026
| // Search for the log we added earlier. | ||
| await Client.WaitPost(() => search.Text = guid.ToString()); | ||
| await ClickControl(refresh); | ||
| await RunTicks(5); |
Member
There was a problem hiding this comment.
Would await Pair.RunUntilSynced() work here?
Contributor
Author
There was a problem hiding this comment.
it is waiting for the list to fill with the given query. there is nothing to sync, so no.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This PR gives the TestAdminLogsWindow a bit more time to load.
Why / Balance
The test is currently unreliable.
Technical details
Wait 10 (instead of 5) ticks after clicking.
Media
No
Requirements
Breaking changes
Changelog